Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire cells sdk integration (#WPB-15743) #3281

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 6, 2025

TaskWPB-15743 [Android] Add KMM SDK version to project

https://wearezeta.atlassian.net/browse/WPB-15743
https://wearezeta.atlassian.net/browse/WPB-15745

What's new in this PR?

  • Wire Cells SDK library is added to kalium:network
  • Uploading file with draft status via aws s3 client sdk with progress
  • Cancelling and publishing drafts
  • Listing files in cell
  • Deleting files in cell

Note: There is no Wire BE support yet. Cells server name and access token are temporary hardcoded for connecting to cells server directly. After Wire will set up proxy connection these credentials will be removed.

Issues

Integration of the wire cells sdk to support new Wire Cells feature.

References
  1. https://wearezeta.atlassian.net/wiki/spaces/AR/pages/1690992716/Wire+Cells+for+Android+Q+1.1
  2. https://wearezeta.atlassian.net/wiki/spaces/PAD/pages/1693319170/2025+01+29+-+Wire+Cells+-+File+Upload+Draft+API

@sbakhtiarov sbakhtiarov requested a review from bsinou February 6, 2025 12:23
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Results

316 tests   307 ✅  39s ⏱️
  6 suites    9 💤
  6 files      0 ❌

Results for commit 5b71d2e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 6, 2025

Datadog Report

Branch report: cell-sdk-integration
Commit report: 3c468b8
Test service: kalium-jvm

✅ 0 Failed, 1 Passed, 0 Skipped, 0s Total Time

@vitorhugods
Copy link
Member

These CI issues can be solved by rebasing the epic branch onto develop, as the actions/upload-artifact was already upgraded there.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbakhtiarov sbakhtiarov merged commit c63441c into epic/wire-cells Feb 21, 2025
17 of 20 checks passed
@sbakhtiarov sbakhtiarov deleted the cell-sdk-integration branch February 21, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants